Load Wizards from AWS Shell data path#151
Open
joguSD wants to merge 8 commits intoawslabs:wizard-featurefrom
Open
Load Wizards from AWS Shell data path#151joguSD wants to merge 8 commits intoawslabs:wizard-featurefrom
joguSD wants to merge 8 commits intoawslabs:wizard-featurefrom
Conversation
Log dropped keys
ab23d8b to
2d233e4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is to get the wizards I've created checked in somewhere and begin the conversation of how wizard models should be integrated with the shell. From previous discussion it seems that each service should have a
wizards-1.jsonfile that has a key corresponding to each of these wizards. With this approach the wizard handler command would likely change from.wizard <name>to.wizard <service> <name>. This would also likely impact the specification for wizard delegation in a similar manner in that the service would also need to be specified. Perhaps rather than the resource being the wizard name directly it would look more like:@JordonPhillips @kyleknap @jamesls